Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43418 )
Change subject: soc/amd/picasso: use FADT devicetree configuration options
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43418/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43418/1//COMMIT_MSG@19
PS1, Line 19: The fadt_pm_profile option is removed from this patch. See commit
: 56da63c3dc3f50cfac541c779b608e1bae9e635c which removed overriding that
: field.
the referenced commit removed the preferred_pm_profile override, so that the option selected by SYST […]
I found a bug in CB:1055 where the SHA in gerrit doesn't match the SHA in the actual git repo. One case. Still, if you can write "commit foobarbaz" in a single line, it should become a clickable link.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e8d0c60cadfdd24b6926703b252abbc56d436de
Gerrit-Change-Number: 43418
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jul 2020 22:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment