[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/pmh7: Fix error conversion from 'int' to 'signed char:1'

[James (Code Review)]

James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34092 )

Change subject: ec/lenovo/pmh7: Fix error conversion from 'int' to 'signed char:1'
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34092/6/src/ec/lenovo/pmh7/chip.h 
File src/ec/lenovo/pmh7/chip.h:

https://review.coreboot.org/c/coreboot/+/34092/6/src/ec/lenovo/pmh7/chip.h@2... 
PS6, Line 21: 	signed char dock_event_enable:1;
The signed single-bit bit field doesn't make sense to me, as the possible values are 0 or -1. It seems to me that the more sensible type is unsigned int or unsigned char, or forgoing bit fields and using uint8_t or bool.