View Change

1 comment:

• File src/ec/lenovo/pmh7/chip.h:

  • Patch Set #6, Line 21: signed char dock_event_enable:1;

    The signed single-bit bit field doesn't make sense to me, as the possible values are 0 or -1. It seems to me that the more sensible type is unsigned int or unsigned char, or forgoing bit fields and using uint8_t or bool.

To view, visit change 34092. To unsubscribe, or for help writing mail filters, visit settings.