Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override if present ......................................................................
Patch Set 22:
(3 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/45459/22/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/22/src/lib/spd_bin.c@148 PS22, Line 148: if (mainboard_get_dram_part_num(spd_name, len)) The default implementation for this function is sitting under chromeos. It won't unconditionally be available.
https://review.coreboot.org/c/coreboot/+/45459/22/src/lib/spd_bin.c@197 PS22, Line 197: memcpy(spd_name, spd_name_ptr, len); spd_name size needs to be taken into account here.
https://review.coreboot.org/c/coreboot/+/45459/22/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/45459/22/src/soc/intel/tigerlake/in... PS22, Line 7: #include <spd_bin.h> What is this #include for?