6 Apr
2022
6 Apr
'22
12:53 p.m.
Attention is currently required from: Sean Rhodes, Martin Roth, Patrick Rudolph, Jakub Czapiga, Matt DeVillier, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: drivers/efi: Add EFI variable store option support ......................................................................
Patch Set 12:
(1 comment)
File src/drivers/efi/efivars.c:
https://review.coreboot.org/c/coreboot/+/52564/comment/5a5e63c4_53d3b3a5 PS12, Line 48: c < 0x80 Isn't char16 is signed? How does this work with negative numbers?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 12
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 06 Apr 2022 12:53:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment