Attention is currently required from: V Sowmya.
Vinay Kumar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54055 )
Change subject: soc/intel/alderlake: Configure FIVR, VR, Turbo ratios
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/54055/comment/f17900fd_5e056497
PS4, Line 329: params->PchFivrExtVnnRailSxEnabledStates = 0x3f;
For Brya board, PchFivrExtV1p05RailEnabledStates, PchFivrExtVnnRailEnabledStates and PchFivrExtVnnRailSxEnabledStates should be set to 0x0(disabled). This is because Brya does not have VNN and V1P05 external bypass rails implemented. Other voltage and Iccmax settings for ExtV1p05/Vnn rails are not required for Brya board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d485872c8bae32f83ebf94bdaa4c6a793976ce7
Gerrit-Change-Number: 54055
Gerrit-PatchSet: 4
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: vagdevi.p@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Comment-Date: Fri, 28 May 2021 12:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment