build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33625 )
Change subject: Fix NULL dereference issues found by Klocwork ......................................................................
Patch Set 1:
(24 comments)
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... File payloads/libpayload/curses/form/fty_alnum.c:
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 166: if(bp == NULL) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 166: if(bp == NULL) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 166: if(bp == NULL) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 167: return result; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... File payloads/libpayload/curses/form/fty_alpha.c:
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 166: if(bp == NULL) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 166: if(bp == NULL) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 166: if(bp == NULL) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 167: return result; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... File payloads/libpayload/curses/form/fty_enum.c:
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 296: if(bp == NULL) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 296: if(bp == NULL) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 296: if(bp == NULL) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 297: return FALSE; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 353: if (bp == NULL) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 353: if (bp == NULL) suspect code indent for conditional statements (2, 3)
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 354: return FALSE; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 394: if(bp == NULL) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 394: if(bp == NULL) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 394: if(bp == NULL) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 395: return FALSE; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... File payloads/libpayload/curses/form/fty_int.c:
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 175: if( bp == NULL) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 175: if( bp == NULL) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 175: if( bp == NULL) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 175: if( bp == NULL) space required before the open parenthesis '('
https://review.coreboot.org/#/c/33625/1/payloads/libpayload/curses/form/fty_... PS1, Line 176: return result; please, no spaces at the start of a line