Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 16:
Patch Set 16:
Patch Set 16:
I'm a bit lost, why Gerrit tells "Merge Conflict" while local git rebases on master OK. Need a good sleep perhaps...
Make,
you have to "fix" missing 'include <device/pci_def.h> in this file 'src/mainboard/amd/thatcher/irq_tables.c' then rebase current patch on it.
Perhaps it would be easier to just create a new change and abandon this one (sorry for being a noob when it comes to resolving these gerrit conflicts :P). I'm going to create a new change soon, if you accept this idea.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37743
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c
Gerrit-Change-Number: 37743
Gerrit-PatchSet: 16
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jan 2020 13:04:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment