[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Move GPIO PM configuration to soc level

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )

Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37685/11/src/soc/intel/common/acpi/... 
File src/soc/intel/common/acpi/platform.asl:

https://review.coreboot.org/c/coreboot/+/37685/11/src/soc/intel/common/acpi/... 
PS11, Line 22: External(_SB.PCI0.EGPM, MethodObj)
> So, do we really need gpio_override_pm flag in coreboot? Anyway we will program it as no matter default(MISCCFG_ENABLE_GPIO_PM_CONFIG) or others. We can just leave this in device tree for all boards, so we don't care the FSP, right?

Reason to have the gpio_override_pm is boards that want to stick to using MISCCFG_ENABLE_GPIO_PM_CONFIG. They technically don't need the override flag to be set in devicetree or any other PM bits to be provided by mainboard. It needs to be set only by those boards that need some configuration that is different than the default.

I think most Intel mainboards wouldn't want to use this override.