[coreboot-gerrit] Change in coreboot[master]: drivers/system76/dgpu: Add driver for System76 switchable graphics

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43615 )

Change subject: drivers/system76/dgpu: Add driver for System76 switchable graphics
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> >
> > (1 comment)
> >
> > AFAIU this isn't s76 specific but very generic code which should work for other boards as well. Why not
>
> I haven't seen any other vendors with NVIDIA GPUs supporting RTD3 using GC6, so I modeled this change after drivers/lenovo/hybrid_graphics.
>
> I agree it probably is more generic, supporting any NVIDIA laptop with fairly recent GPUs, but I have no non-System76 hardware that is supported by coreboot to compare with.

I see. Hmm, lenovo does some more bits but the gpio mechanism seems so be similiar. The lenovo driver is for older platforms, though (src/southbridge). IMHO that could have been done in ageneric way, too, while providing optional vendor additions.