[coreboot-gerrit] Change in coreboot[master]: fw_config: Add firmware configuration interface

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )

Change subject: fw_config: Add firmware configuration interface
......................................................................

Patch Set 13:

(3 comments)

https://review.coreboot.org/c/coreboot/+/41209/13/src/include/fw_config.h 
File src/include/fw_config.h:

https://review.coreboot.org/c/coreboot/+/41209/13/src/include/fw_config.h@41 
PS13, Line 41: fw_config_probe
does this function need to be exposed?

https://review.coreboot.org/c/coreboot/+/41209/13/src/lib/fw_config.c 
File src/lib/fw_config.c:

https://review.coreboot.org/c/coreboot/+/41209/13/src/lib/fw_config.c@32 
PS13, Line 32: 	/* Look in CBFS to allow override of value. */
should we still query the EC if we have an override?

https://review.coreboot.org/c/coreboot/+/41209/13/src/lib/fw_config.c@70 
PS13, Line 70: match
this is an invariant... or better be :)