Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47148 )
Change subject: drivers/intel/dptf: Generate ACPI identifiers only for enabled devices ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47148/1/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/47148/1/src/drivers/intel/dptf/dptf... PS1, Line 235: if (!dev->enabled) : return; : I wonder - shouldn't we fix this at the source? i.e. the caller should not make the `acpi_fill_ssdt` call if device is not enabled. I think we have been adding these checks for a while now, but it seems unnecessary within the individual drivers. With the check at the caller site, we can drop all the dev->enabled checks from all these individual drivers. Thoughts?