Attention is currently required from: Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43759 )
Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
Please test if this changes binaries built with our reference toolchain.
The binary does not change.
$ make crossgcc-i386 $ git describe 4.15-1078-g50251400d2 $ more defconfig CONFIG_VENDOR_PURISM=y CONFIG_CBFS_SIZE=0xA00000 CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x20000 CONFIG_BOARD_PURISM_LIBREM_MINI_V2=y CONFIG_UART_PCI_ADDR=0x0 CONFIG_SUBSYSTEM_VENDOR_ID=0x0000 CONFIG_SUBSYSTEM_DEVICE_ID=0x0000 CONFIG_PAYLOAD_NONE=y $ make BUILD_TIMELESS=1 […] $ md5sum build/coreboot.rom 6aea50216952865c61f8bef2c7dd768b build/coreboot.rom $ git fetch https://review.coreboot.org/coreboot refs/changes/59/43759/11 && git cherry-pick FETCH_HEAD $ make BUILD_TIMELESS=1 […] $ md5sum build/coreboot.rom 6aea50216952865c61f8bef2c7dd768b build/coreboot.rom