[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien: Fix s5 touchscreen power leakage

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32367 )

Change subject: mb/google/sarien: Fix s5 touchscreen power leakage
......................................................................

Patch Set 12:
> Patch Set 12:
> > Patch Set 11:
> > > Patch Set 11:
> > > > Patch Set 11:
> > > > > Patch Set 11:
> > > > > > Patch Set 11:
> > > > > >
> > > > > > (1 comment)
> > > > >
> > > > > There is each CL for both arcada and sarien in which both GPP_E7 and GPP_B21 are being controlled in S0iX.
> > > > >
> > > > > For arcarda,
> > > > > https://review.coreboot.org/c/coreboot/+/32311
> > > > >
> > > > > For sarien,
> > > > > https://review.coreboot.org/c/coreboot/+/32330
> > > >
> > > > Aah interesting. So, the same power resource would ideally work with crrev.com/c/1577858 in kernel even for S5.
> > >
> > > So I shall continue to make the change?
> >
> > I meant try out the kernel change(crrev.com/c/1577858) without the change in .asl to see if the touchscreen power looks good in S5.
>
> Hi Furquan,
>
> I tested with your kernel change(crrev.com/c/1577858) wo/ the change in .asl.
> And it also fixed leakage power on RESET (GPP_E7) in S5.

Thanks for the confirmation Roy. I am preparing the CL for upstream review. I will let you know how it goes. If it gets accepted, we should not require any ASL changes.