Attention is currently required from: Mike Banon, Marshall Dawson, Paul Menzel, Kyösti Mälkki.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38313 )
Change subject: AGESA,binaryPI boards: Drop invalid MP table files
......................................................................
Patch Set 8: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/38313/comment/283a2c49_ad4fa92d
PS8, Line 10: broken copy-paste.
Sooo, if no AGESA board has a valid MP table... […]
Great idea, thank you a lot, this is a right approach. And the patches mentioned by Paul:
1. [[coreboot] PIC instead of APIC mode for KolibriOS - mouse fix](https://mail.coreboot.org/pipermail/coreboot/2014-May/077913.html)
2. [[coreboot] PIC instead of APIC mode for KolibriOS - mouse fix](https://mail.coreboot.org/pipermail/coreboot/2014-May/077942.html)
- these pci_write_config32 could be moved from a patch's mptable.c to another file like mainboard.c
Patchset:
PS6:
I will re-test Kolibri with MPTables dropped and report the results here, to fully resolve this issu […]
Kolibri and other floppy OS from my CB:33509 collection - are still working fine even without MP tables, i.e. Kolibri still sees the interrupts and USB is working good.
Patchset:
PS8:
Considering the new findings (see comments below), it's safe to +2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd13b8b006fce7383f3f73c3c0a5d51a71c0155b
Gerrit-Change-Number: 38313
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 16 Mar 2021 21:08:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment