SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34397 )
Change subject: mb/google/kohaku: Update DPTF parameters and TDP PL1/PL2
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34397/6/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34397/6/src/mainboard/google/hatch/...
PS6, Line 2: 8
does this need to be updated to 15 now?
I don't think so. We might use 8W PL1 in case of DPTF not working.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a87ff88e8e14ada473f9da59c15cdc779cbb108
Gerrit-Change-Number: 34397
Gerrit-PatchSet: 6
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Ben Kao
ben.kao@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Grace Kao
grace.kao@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Fri, 26 Jul 2019 00:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment