HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )
Change subject: sc7180: GPIO: Add I2S configuration for sc7180
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38593/6/src/soc/qualcomm/sc7180/qi2...
File src/soc/qualcomm/sc7180/qi2s.c:
https://review.coreboot.org/c/coreboot/+/38593/6/src/soc/qualcomm/sc7180/qi2...
PS6, Line 16: #include <arch/cache.h>
: #include <device/mmio.h>
: #include <soc/addressmap.h>
: #include <soc/gpio.h>
: #include <soc/clock.h>
: #include <symbols.h>
: #include <assert.h>
: #include <gpio.h>
: #include <string.h>
: #include <soc/qi2s.h>
Looks like you don't use all of those includes.
Please check, and include only what you use.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I681aa6d0d57671b0fd9b7bc88de6f2cc202a7af0
Gerrit-Change-Number: 38593
Gerrit-PatchSet: 6
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 07 Feb 2020 19:18:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment