Attention is currently required from: Bao Zheng, ritul guru, Zheng Bao.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 )
Change subject: amdfwtool: Allow the location to be a relative address
......................................................................
Patch Set 15:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/69856/comment/4cb32c74_e58963a4
PS12, Line 2462: if (efs_location & 0xFF000000)
: efs_location = efs_location - rom_base_address;
: if (body_location & 0xFF000000)
: body_location = body_location - rom_base_address;
Add a special case.
I like how that turned out. Are the `0xFFFA0000` or `0xFFE20000` offsets ever used on 8M ROMs? To be safe, it is probably best to add the `0x620000` and `0x7A0000` cases for 8M
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4308ec9ea05a87329aba0b409508c79ebf42325c
Gerrit-Change-Number: 69856
Gerrit-PatchSet: 15
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Wed, 01 Feb 2023 13:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment