Attention is currently required from: Chao Gui, Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71610 )
Change subject: mb/google/skyrim: Create markarth variant
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71610/comment/29d20727_321d7bde
PS1, Line 12: (Auto-Generated by create_coreboot_variant.sh version 4.5.0).
Please move the dot/period before the ).
It would be even be better if the script in the Chromium repository could be fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71610
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbace841ca56d8659aaffdc31fb2bc4367d96f82
Gerrit-Change-Number: 71610
Gerrit-PatchSet: 1
Gerrit-Owner: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Isaac Lee
isaaclee@google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Chao Gui
chaogui@google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 02 Jan 2023 09:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment