Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46855 )
Change subject: mrc_cache: Move code for triggering memory training into mrc_cache ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46855/8/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46855/8/src/drivers/mrc_cache/mrc_c... PS8, Line 609: so it's safe to use the mrc_cache : * data. This path is not using the cache data. Probably say: "so normal mode cache does not need to be invalidated".
https://review.coreboot.org/c/coreboot/+/46855/8/src/drivers/mrc_cache/mrc_c... PS8, Line 616: invalidate when : * retrain switch is set. Probably invert the comment i.e. no need to invalidate the cache if retrain switch is not set.
(Reason: All these checks in the function are for deciding if we want to skip the invalidation. If none of them match, then we will invalidate cache.)
https://review.coreboot.org/c/coreboot/+/46855/8/src/drivers/mrc_cache/mrc_c... PS8, Line 695: 0 Please see comment on patchset 6.