Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/haswell.go File util/autoport/haswell.go:
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/haswell.go@1... PS13, Line 13: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, Do we need this?
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go... PS13, Line 87: /* TODO: create it as header files as other boards */ no.
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go... PS13, Line 326: 1 if b.variant == LYNX_POINT_ULT, this should be 5
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go... PS13, Line 585: /* SDIO */ : RegisterPCI(0x8086, 0x9c35, GenericPCI{}) : : /* Smart Sound Technology Controller */ : RegisterPCI(0x8086, 0x9c36, GenericPCI{}) : : /* Serial I/O */ : for id := uint16(0x9c60); id <= 0x9c66; id++ { : RegisterPCI(0x8086, id, GenericPCI{}) : } These probably don't apply to desktops