Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38648 )
Change subject: util/cbfstool: extend includes in commonlib ......................................................................
Patch Set 3:
(1 comment)
HOSTCC cbfstool/lz4_wrapper.o/usr/home/idwer/github.com/coreboot/coreboot/src/commonlib/bsd/lz4_wrapper.c:5:10: fatal error: 'endian.h' file not found #include <endian.h> ^~~~~~~~~~
It does that even with the -I/usr/include/sys, when you have a /usr/include/sys/endian.h? Strange...
Well, I guess there's nothing wrong with doing the sysincludes thing to fix it.
https://review.coreboot.org/c/coreboot/+/38648/2/src/commonlib/bsd/include/c... File src/commonlib/bsd/include/commonlib/bsd/sysincludes.h:
https://review.coreboot.org/c/coreboot/+/38648/2/src/commonlib/bsd/include/c... PS2, Line 5: #endif If we're doing this I'd suggest we do it for all system includes in commonlib/bsd (e.g. <assert.h>, <endian.h>, <stdbool.h>, <stddef.h>, <stdint.h> and <string.h>), and include it from all those files in place of the individual headers.