[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/dedede/var/boxy: Add wait for HPD function

[Derek Huang (Code Review)]

Attention is currently required from: Joey Peng.

Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email )

Change subject: mb/google/dedede/var/boxy: Add wait for HPD function
......................................................................

Patch Set 1:

(1 comment)

File src/mainboard/google/dedede/variants/boxy/ramstage.c:

https://review.coreboot.org/c/coreboot/+/78146/comment/f27df7b6_e35a250e :
PS1, Line 63: 	static const long display_timeout_ms = 3000;
            : 
            : 	if (display_init_required()
            : 		&& !gpio_get(GPIO_USB_C0_HPD)) {
            : 		/* This has to be done before FSP-S runs. */
            : 		if (google_chromeec_wait_for_displayport(display_timeout_ms)){
            : 			wait_for_hpd(GPIO_USB_C0_HPD, display_timeout_ms);
            : 		}
            : 	}
            : 	else if (display_init_required()
            : 		&& !gpio_get(GPIO_USB_C1_HPD)) {
            : 		/* This has to be done before FSP-S runs. */
            : 		if (google_chromeec_wait_for_displayport(display_timeout_ms)){
            : 			wait_for_hpd(GPIO_USB_C1_HPD, display_timeout_ms);
            : 		}
            : 	}
It's better to implement this in a separate function, e.g. variant_display_init. Call this function from dedede/mainboard.c