Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45373 )
Change subject: soc/intel/common/block: Do not die if PRMRR size unsupported
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45373/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/45373/1/src/soc/intel/common/block/...
PS1, Line 373: BIOS_WARNING
This is more an error than a warning, since programming PRMRR seems to be a *must* (see the check in chipsec), even when it's 0. Initially, that was the reason to die here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45373
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib917be873aedbc5e789bb0894fca335b5ee9e2c2
Gerrit-Change-Number: 45373
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Sep 2020 07:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment