Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39964 )
Change subject: mb/google/cyan: convert to overridetree
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/d...
File src/mainboard/google/cyan/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/d...
PS1, Line 110: device pci 12.0 off end # 8086 0F16 - SD Port
looks like it was an old pre-commit hook that generated that error. […]
For any future eyeballs that may come across these writings: an overridetree needs to have at least one device. This device can be "device domain 0 on end"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39964
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9928cc59adcfda4661ddfdfa95f53a7820053b4a
Gerrit-Change-Number: 39964
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Apr 2020 21:26:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment