Attention is currently required from: Mac Chiang, Paul Menzel, Varun Upadhyay, Weimin Wu.
Pranava Y N has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85572?usp=email )
Change subject: mb/google/fatcat/var/felino: Add ALC712 codec to devicetree
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/felino/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85572/comment/217f1f84_1775f9bb?usp... :
PS6, Line 297: MIPI_DEV_ID_REALTEK_ALC712
This part ID is not defined. Please fix this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85572?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5c38462cd1ab39d4aebc324d5151cb4337051df
Gerrit-Change-Number: 85572
Gerrit-PatchSet: 6
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mac Chiang
mac.chiang@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Apr 2025 05:31:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No