Attention is currently required from: Maulik V Vaghela, Sridhar Siricilla, Subrata Banik, Balaji Manigandan, Deepti Deshatty, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55230 )
Change subject: soc/intel/alderlake: Correct TCSS XHCI Port status offset
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/alderlake/xhci.c:
https://review.coreboot.org/c/coreboot/+/55230/comment/3de69ad7_3f82d954
PS1, Line 18: 0x490
@Tim, I'm working with our internal teams for doc update. sorry for the confusion.
Oh oops I had PCH on the brain, you're right, thanks.
https://review.coreboot.org/c/coreboot/+/55230/comment/c4548ba9_43682e14
PS1, Line 19: 10
This needs correction as well since ADL-P CPU doesn't support USB2 ports. […]
You're right, should be 0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55230
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20c77d78f52277a9a979e11303cdb6cdabae7c59
Gerrit-Change-Number: 55230
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment