Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44107 )
Change subject: mb/google/zork/ezkinil: Fix ELAN touchscreen ACPI node
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/ezkinil/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44107/1/src/mainboard/google/zork/v...
PS1, Line 83: 300
Does this delay of 300ms match the spec?
I see from the bug that the 300ms is the recommended delay. Just a note that this 300ms would result in adding delay to both boot and resume paths. Some other projects have been able to reduce this delay to 100ms (IIRC). So, it would be good to see if that is an option here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d4dcb6e5cae5d9515abfd415315ec4114ca80b4
Gerrit-Change-Number: 44107
Gerrit-PatchSet: 1
Gerrit-Owner: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Teresa Tseng
teresa_tseng@quanta.corp-partner.google.com
Gerrit-CC: Vincent Wang
vwang@chromium.org
Gerrit-Comment-Date: Mon, 03 Aug 2020 20:36:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment