Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/27094 )
Change subject: mainboard/google/nocturne: Set camera power sequence ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl:
https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/... PS3, Line 155: Name (_CRS, ResourceTemplate () Since the NVM0 requires the IMX355 sensor module to be powered, we should also be adding the dependencies for the front camera power resources.
Name (_DEP, Package() { ^^I2C5.CAM0 })
Name (_PR0, Package (0x01) { ^^I2C5.CAM0.RCPR }) Name (_PR3, Package (0x01) { ^^I2C5.CAM0.RCPR })
https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/... PS3, Line 167: 1 32
Page size is 32 bytes, per the NVM data sheet.
https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl:
https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/... PS3, Line 136: 1 32
Page size is 32 bytes, per the NVM data sheet.