Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68245 )
Change subject: soc/amd/common: Remove buildtime error for unknown cpu
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/common/block/psp/psp_efs.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160055):
https://review.coreboot.org/c/coreboot/+/68245/comment/68e91d09_850bdaea
PS1, Line 29: printk(BIOS_ERR,"Unknown cpu in psp_efs.h\n");
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160055):
https://review.coreboot.org/c/coreboot/+/68245/comment/ca970a00_60964ecd
PS1, Line 30: printk(BIOS_ERR,"SPI speed/mode not set.\n");
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib02bbe1f9ffb343e1ff7c2bfdc45e7edffe7aaed
Gerrit-Change-Number: 68245
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 08 Oct 2022 23:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment