Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41437 )
Change subject: soc/amd/picasso/acpi: Move _PIC method to root namespace
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41437/2/src/soc/amd/picasso/acpi/pc...
File src/soc/amd/picasso/acpi/pci_int.asl:
https://review.coreboot.org/c/coreboot/+/41437/2/src/soc/amd/picasso/acpi/pc...
PS2, Line 112: printf("PIC MODE: %o", Arg0)
Felix you should mark these as resolved then.
not sure what you mean; it is marked as resolved here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41437
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd5e9646df8d56e7cbec2be8b4016c36d81e5fb8
Gerrit-Change-Number: 41437
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 May 2020 19:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment