Attention is currently required from: Appukuttan V K, Jérémy Compostella, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81680?usp=email )
Change subject: arch/x86/bootblock.ld: Avoid the overlap between .text and .init
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
It's probably worth investigating why that region is overflowing, rather than adding random numbers till it works. It's a good method of diagnosing the problem though. Do you have a patch train that I could try out to reproduce your issue?
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/81680/comment/a7ca42e3_f499a1ca :
PS1, Line 29: SIZEOF(.data)
don't remove this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81680?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic6877f7d64487cd893e86525fd5c41582507ec7a
Gerrit-Change-Number: 81680
Gerrit-PatchSet: 1
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Fri, 05 Apr 2024 13:07:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment