Attention is currently required from: Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72788 )
Change subject: Intel TPM works, troubleshooting potential battery charge not being shown Added ITE8987e superio/EC ......................................................................
Patch Set 1:
(347 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b3ffb421_6583506a PS1, Line 6: Possible long commit subject (prefer a maximum 65 characters)
File src/mainboard/acer/swift3-SF314-52G-55WQ/acpi/battery.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/361073d3_08ac1101 PS1, Line 13: Zero, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2e5a0dd3_a9303996 PS1, Line 14: 0xFFFFFFFF, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/58e302c0_6e5e71e8 PS1, Line 15: 0xFFFFFFFF, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/60bbb6dc_d630d7e3 PS1, Line 16: One, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ca61e463_820b294c PS1, Line 17: 0xFFFFFFFF, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2b2738ab_ddb97300 PS1, Line 18: 0xFFFFFFFF, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d9dd0206_9c39f4b4 PS1, Line 19: 0xFFFFFFFF, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/23e06267_e7659264 PS1, Line 20: 0xFFFFFFFF, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7ff4f7ae_12665e04 PS1, Line 21: 0xFFFFFFFF, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/431799eb_eeffb1dd PS1, Line 22: "", trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d19553d9_35949df9 PS1, Line 23: "", trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7c18a511_c6829bee PS1, Line 24: "", trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/de152191_1c9eb357 PS1, Line 185: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/a2a2b27f_db7fef22 PS1, Line 202: } trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ac913019_521af702 PS1, Line 377: Local0 = B1FC trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cd21f107_2c5405de PS1, Line 381: Local0 = B0FC trailing whitespace
File src/mainboard/acer/swift3-SF314-52G-55WQ/acpi/ec.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2ee256fe_2018f8e0 PS1, Line 96: Offset (0x01), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7c7303df_93500124 PS1, Line 97: EPWS, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f6c09b05_3645a394 PS1, Line 98: EB0S, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/799adff4_29c76e8b PS1, Line 99: EB1S, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/443bb6eb_346ef0ae PS1, Line 100: EB0R, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ea68dfee_01d5eab5 PS1, Line 101: EB1R, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0b753007_fcf6c687 PS1, Line 102: EB0T, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/406c3dad_10f05ed5 PS1, Line 103: EB1T, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/78f1f305_1ddb19b9 PS1, Line 104: OCOT, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/db881f4d_502dbaae PS1, Line 105: Offset (0x10), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5b426f60_ad98d90c PS1, Line 106: B0PN, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f0407805_85d121d5 PS1, Line 107: B0VL, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cc392f81_6b8aa004 PS1, Line 108: B0RC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d9c48fe8_3219413d PS1, Line 109: B0FC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f0184a67_bd197169 PS1, Line 110: B0ST, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b43f334c_f851d695 PS1, Line 111: B0CC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e98fad0f_68dadc3c PS1, Line 112: B0TM, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/aaf98617_e5ea1da8 PS1, Line 113: B0C1, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2975a018_75029279 PS1, Line 114: B0CV, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2fa9540e_9ff91c9a PS1, Line 115: Offset (0x30), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d8f7bbea_1f665458 PS1, Line 116: B1PN, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cfe85dfd_4fd0f094 PS1, Line 117: B1VL, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9f26813d_7cc63f85 PS1, Line 118: B1RC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d63d48d4_24baec5a PS1, Line 119: B1FC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3a68b252_7cb735df PS1, Line 120: B1ST, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7fe3b399_11eab8ff PS1, Line 121: B1CC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9652963a_24b6befc PS1, Line 122: B1TM, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/63f58942_a35360cb PS1, Line 123: B1C1, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9e9c1c11_6c9bf246 PS1, Line 124: B1CV, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/bede0ed5_fcbd932f PS1, Line 125: Offset (0x50), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/45590a91_47cc55fb PS1, Line 126: B0DC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/1237ce55_211afd41 PS1, Line 127: B0DV, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/add72668_969a8ab5 PS1, Line 128: B0SN, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b3472460_4f2804ed PS1, Line 129: B0MD, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2b3bf27e_7cab8faf PS1, Line 130: B1DC, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d1973256_ce5bf413 PS1, Line 131: B1DV, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/95129c42_013ebf8c PS1, Line 132: B1SN, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4ad1647d_a0b794e2 PS1, Line 133: B1MD, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/35694f04_bf9e809d PS1, Line 134: TH1R, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7d4abaad_bf9eef66 PS1, Line 135: TH1L, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6597a046_57f2dd18 PS1, Line 136: TH0R, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/29b938ba_095014e8 PS1, Line 137: TH0L, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7e6e416b_6584838c PS1, Line 138: ECRT, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f187bc89_0d039780 PS1, Line 139: EPSV, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/05c0c3df_32d1ce34 PS1, Line 140: EACT, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/99fe4a53_8f751280 PS1, Line 141: TERR, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/689ca2aa_6ff1605d PS1, Line 142: F0TS, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d4e2e0ca_d2b4361e PS1, Line 143: F1TS, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d1293376_467f8192 PS1, Line 144: F0CS, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/77b8c391_bbfa0fd1 PS1, Line 145: F1CS, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/156a277e_31b65dad PS1, Line 146: PCPT, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d9943a63_5aaffca7 PS1, Line 147: ALSC, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/798131c2_84af5f7f PS1, Line 148: Offset (0x72), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/51f60530_59fcb801 PS1, Line 149: ALSU, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c030120c_1a971e4f PS1, Line 150: ALSL, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6e59572a_8063d5ac PS1, Line 151: ALSX, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0c184ae3_f797602c PS1, Line 152: BRTC, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9056b001_9b3de237 PS1, Line 153: BCDV, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/8fab13c0_8cd8fb08 PS1, Line 160: ESEM, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4d6f760f_72e937b2 PS1, Line 161: CMD1, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/bec60a7c_55cf1246 PS1, Line 162: CDT1, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/25113b5a_3dab7e94 PS1, Line 163: CDT2, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/49f534dc_7ea19292 PS1, Line 164: CDT3, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/1a82c5a5_2437ddb5 PS1, Line 165: CDT4, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/8523636a_3cef8f65 PS1, Line 166: CDT5, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e5e976cf_9e930145 PS1, Line 167: CDT6, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cb0abffc_f4f47dd3 PS1, Line 168: CDT7, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2dfebd2d_083f3d0c PS1, Line 169: CDT8, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/711c797f_90034c40 PS1, Line 170: CDT9, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/227500a2_94651dba PS1, Line 171: CD10, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6459954c_45853208 PS1, Line 172: CD11, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5015ee3d_ed7e00fa PS1, Line 173: CD12, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6802fc38_d0923b0f PS1, Line 174: Offset (0x40), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/abedce23_c47ebe1f PS1, Line 175: EDA1, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/48ca4de9_2c8a3b15 PS1, Line 176: EDA2, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/57404363_4a37f6a4 PS1, Line 177: EDA3, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/eaf76aba_9a22b07b PS1, Line 178: EDA4, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f3252c59_26d1d25a PS1, Line 179: EDA5, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/71afe477_179bdc78 PS1, Line 180: EDA6, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/77b0ce5d_4929c92d PS1, Line 181: EDA7, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/dc7ae88d_9a156663 PS1, Line 182: EDA8, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b2a6555d_68fa09e0 PS1, Line 183: EDA9, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/021b4a67_2d5392b9 PS1, Line 184: ED10, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7b307631_6eb90f90 PS1, Line 185: ED11, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0ef4d398_aa96b343 PS1, Line 192: PKBD, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/536648ff_f229c752 PS1, Line 193: Offset (0x02), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/543abcf8_c8631c2f PS1, Line 194: Offset (0x03), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e4c3b15c_ef0f5e0f PS1, Line 195: Offset (0x04), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d21192c1_a16af606 PS1, Line 202: Offset (0x40), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/409a2912_fe312e3e PS1, Line 203: Offset (0x41), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/33c6df20_d62d2607 PS1, Line 204: BCNT, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/84d6b146_86e13b12 PS1, Line 336: } trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0e453c8c_99fa95a8 PS1, Line 389: 0x07, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/31906ce1_52e9d427 PS1, Line 390: Zero, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f8a5ed9b_949211eb PS1, Line 687: 0x10, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/70a0cd02_352f02c3 PS1, Line 688: Zero, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/16f0f3df_c659a71c PS1, Line 689: Zero, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/12a0b5fd_fa8a1e95 PS1, Line 690: Zero, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/dc71948d_6a921eaf PS1, Line 691: Zero, trailing whitespace
File src/mainboard/acer/swift3-SF314-52G-55WQ/acpi/mainboard.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cbbee7aa_193ca2ba PS1, Line 32: EIND, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0e8b6d16_54dbc304 PS1, Line 38: Offset (0xE0), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/94387e87_a0ace896 PS1, Line 39: RAMB, 32, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b644f14f_f8dfc6d8 PS1, Line 40: OTPE, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/33cc207d_a7aa092a PS1, Line 41: RESV, 24, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/273df5f2_884f7bdc PS1, Line 42: CTPF, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c0fe1dc4_e3671337 PS1, Line 43: WLDP, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/db4a4772_a3564565 PS1, Line 44: BTDP, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/846568a8_bc0b6ea2 PS1, Line 45: RES1, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f8fc6b94_49489825 PS1, Line 46: WRST, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2d27d41a_32303e19 PS1, Line 47: BRST, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9168a13f_0c3076ec PS1, Line 48: RES2, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5c5a18f2_01289503 PS1, Line 49: FSCU, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/67a2df8e_319653fa PS1, Line 50: RSDF, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5ade0824_8d5a7c94 PS1, Line 51: ABTY, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/24d6ff59_8f187b6c PS1, Line 52: FANS, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/61c264f3_bb5ce380 PS1, Line 53: WWKS, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0558856c_e0dfedf1 PS1, Line 54: PFNS, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0eaa8292_139dfb90 PS1, Line 55: FGPU, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e755cacd_763c1a08 PS1, Line 56: RES4, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3e765993_784c6a95 PS1, Line 57: CLS1, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/623e6ee9_991e6d54 PS1, Line 58: CLS2, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cc59c46a_57bc4ee1 PS1, Line 59: CLS3, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4fa574e2_f021fa72 PS1, Line 60: CLS4, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7b403a71_ac2396a9 PS1, Line 61: CLS5, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/247fef55_2f50a997 PS1, Line 62: QFKF, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6ac568c6_e229dd88 PS1, Line 63: LBAR, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5a8da364_a7e2b8eb PS1, Line 64: KBLD, 4, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cde5fea8_ee2a2fa3 PS1, Line 65: S3TL, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/96f3d780_be4f6af7 PS1, Line 66: S3TH, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/62d3c536_146e7d62 PS1, Line 67: ES3M, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c3eee36b_cc0b55d1 PS1, Line 68: SS3F, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/880ad8d8_3d882e85 PS1, Line 69: ADAP, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/1ae8902d_279b2e78 PS1, Line 70: LOCS, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/bf467871_f9c17e0c PS1, Line 71: RES3, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c08608b4_a9254146 PS1, Line 72: I2CT, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/25c449b0_6f3f50be PS1, Line 73: TCTP, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3865da95_9f9b7083 PS1, Line 74: KBLS, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5aab0dbe_39adf866 PS1, Line 75: KBST, 1, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/42ae93a0_23d862fd PS1, Line 76: RES5, 2, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/29c39b3e_2ad84a61 PS1, Line 77: RES6, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c26aa62b_892fcdb3 PS1, Line 78: LDDF, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f9c2baa7_59067dbd PS1, Line 79: S3FA, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/775b3402_2c0f204d PS1, Line 80: POS0, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/de124768_9a40d9e2 PS1, Line 81: POS1, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ff793dac_46618606 PS1, Line 82: POS2, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2b64b5a6_e5389b7d PS1, Line 83: POS3, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5e2fb228_e28c1eed PS1, Line 84: POS4, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/a8425e11_96371622 PS1, Line 85: POS5, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e4fd837c_a53e0368 PS1, Line 86: MANN, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/19c4f5cb_ed76b224 PS1, Line 87: ISXX, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f6f4b745_2ed910af PS1, Line 94: TT_P, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/1cc0c941_b72131da PS1, Line 95: FS_F, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/761621d5_6c8ab0b8 PS1, Line 96: FS_T, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/32e24867_36d695e0 PS1, Line 97: FA_D, 32, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3a276685_3438d403 PS1, Line 98: FS_Z, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/8740bee9_e4a83b16 PS1, Line 99: ST_P, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/10026e61_3e889fa4 PS1, Line 100: MN_A, 64, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3d56e871_ef3cc9b4 PS1, Line 101: BT_P, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cad9e2dc_d184993d PS1, Line 102: AL_D, 32, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/8b8009c5_864e4586 PS1, Line 103: DB_1, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b3ce4c88_34855908 PS1, Line 104: DB_2, 32, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/08dd6fdd_ee5890fc PS1, Line 105: DB_3, 32, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d48dda79_b36f23cb PS1, Line 106: DB_4, 32, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/119896dc_e08f74a5 PS1, Line 107: RT_W, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5a111c5a_606f7a40 PS1, Line 108: PM_B, 32, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5363a5f8_4ea6ffd6 PS1, Line 109: PM_S, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/30f2d9a4_c07531d9 PS1, Line 110: AC_F, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e67ed3ae_3ee64c1b PS1, Line 111: DC_F, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/134221be_0e4564c7 PS1, Line 112: DC_2, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2f241059_d3bacfa6 PS1, Line 113: VG_F, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/849cd309_0ef666ca PS1, Line 114: PD_L, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/59edb297_1f107bc1 PS1, Line 115: CD_L, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6bc840b7_fadc31a4 PS1, Line 116: CD_S, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4fc71658_da37fb7e PS1, Line 117: ND_S, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d78ca4a5_972421d7 PS1, Line 118: SD_S, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d42bc45f_6781d2da PS1, Line 119: CN_R, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/554bfcd0_f2943870 PS1, Line 120: TJ_M, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7b0ae3a0_c0b9f2d6 PS1, Line 121: TR_T, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/268341a7_94578d03 PS1, Line 122: CR_T, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c4e6f96a_501ca438 PS1, Line 123: PC_P, 8, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/815833d0_1bf5952e PS1, Line 124: S3_E, 16, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3aa44b7a_105887cb PS1, Line 125: S3_B, 16, trailing whitespace
File src/mainboard/acer/swift3-SF314-52G-55WQ/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d9d09a8d_19661fe4 PS1, Line 49: switch(combined) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/477e973a_0c543963 PS1, Line 49: switch(combined) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/fba265d9_4df22ae6 PS1, Line 79: gpio_set(VGA_AON_PWR_EN, 0); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/70a7910d_098556fb PS1, Line 79: gpio_set(VGA_AON_PWR_EN, 0); please, no spaces at the start of a line
File src/mainboard/acer/swift3-SF314-52G-55WQ/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9cd1ed77_c4e605fd PS1, Line 21: # size is calcualted: size = (0x3 | ((gen_io_dec >> 16) & 0xfc)) + 1; 'calcualted' may be misspelled - perhaps 'calculated'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ac626025_2f5e804b PS1, Line 349: end trailing whitespace
File src/mainboard/acer/swift3-SF314-52G-55WQ/gpio_early.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6b585dec_eff74ae7 PS1, Line 52: /* DW0: 0x84000400, DW1: 0x00000000 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/064b402f_78bb5a0c PS1, Line 53: /* DW0: PAD_TRIG(OFF) - IGNORED */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/687cfc78_bdedce2a PS1, Line 54: /* PAD_CFG_NF(GPP_B13, NONE, PLTRST, NF1), */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7d59f9dc_1dd9500c PS1, Line 55: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF), 0), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5a2dc808_09f4c5d9 PS1, Line 55: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF), 0), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d86d6643_37e76083 PS1, Line 57: /* GPD4 - SLP_S3# */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4e0df6dc_c63fd975 PS1, Line 58: /* DW0: 0x44000400, DW1: 0x00000000 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/aaa00b26_a5fb4085 PS1, Line 59: /* DW0: PAD_TRIG(OFF) - IGNORED */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3629b081_feaaff00 PS1, Line 60: /* PAD_CFG_NF(GPD4, NONE, DEEP, NF1), */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/36eb686b_0a6f530e PS1, Line 61: _PAD_CFG_STRUCT(GPD4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), 0), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0ad62c33_b5bea28c PS1, Line 61: _PAD_CFG_STRUCT(GPD4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), 0), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7bde1db4_32f8c8ce PS1, Line 63: /* GPD5 - SLP_S4# */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c2dc802c_c990ddfc PS1, Line 64: /* DW0: 0x44000400, DW1: 0x00000000 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f18143db_9d44e862 PS1, Line 65: /* DW0: PAD_TRIG(OFF) - IGNORED */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ef5b9b13_5e53a8c8 PS1, Line 66: /* PAD_CFG_NF(GPD5, NONE, DEEP, NF1), */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cf2e08c4_1a469392 PS1, Line 67: _PAD_CFG_STRUCT(GPD5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), 0), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7cf02067_a2087aac PS1, Line 67: _PAD_CFG_STRUCT(GPD5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), 0), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ae27dd48_af47741e PS1, Line 69: /* GPD8 - SUSCLK */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b345c40b_9cec9888 PS1, Line 70: /* DW0: 0x44000400, DW1: 0x00000000 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e1e5845e_532a3f2a PS1, Line 71: /* DW0: PAD_TRIG(OFF) - IGNORED */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/36eeed97_25d76d4f PS1, Line 72: /* PAD_CFG_NF(GPD8, NONE, DEEP, NF1), */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/67562fae_2d276cd3 PS1, Line 73: _PAD_CFG_STRUCT(GPD8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), 0), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/beee27d9_a6ac0fd1 PS1, Line 73: _PAD_CFG_STRUCT(GPD8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), 0), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/dcee1e6e_4fa16c47 PS1, Line 75: /* GPP_A8 - CLKRUN# */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/137f4224_88ac6187 PS1, Line 76: /* DW0: 0x84000402, DW1: 0x00000000 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6948ecb9_97123bde PS1, Line 77: /* DW0: PAD_TRIG(OFF) | (1 << 1) - IGNORED */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0dc6fed2_d0ed5589 PS1, Line 78: /* PAD_CFG_NF(GPP_A8, NONE, PLTRST, NF1), */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/439cca9e_4d0e5375 PS1, Line 79: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | (1 << 1), 0), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/00e6c737_37752d5b PS1, Line 79: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | (1 << 1), 0), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e3644c58_066a8379 PS1, Line 81: /* GPP_A9 - CLKOUT_LPC0 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/8bc92c30_10369c5c PS1, Line 82: /* DW0: 0x84000400, DW1: 0x00000000 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ea68444e_fadcaa2c PS1, Line 83: /* DW0: PAD_TRIG(OFF) - IGNORED */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/858fd629_a76d6053 PS1, Line 84: /* PAD_CFG_NF(GPP_A9, NONE, PLTRST, NF1), */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/a607ef5d_e3d8598b PS1, Line 85: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF), 0), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ba68eafa_e87bbe84 PS1, Line 85: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF), 0), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e2afdd7a_bd1ea5b0 PS1, Line 87: /* GPP_A10 - CLKOUT_LPC1 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9f6327fb_7218c92f PS1, Line 88: /* DW0: 0x84000400, DW1: 0x00000000 */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4a6c11ed_94dff1c6 PS1, Line 89: /* DW0: PAD_TRIG(OFF) - IGNORED */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/63fbef8a_09dab89c PS1, Line 90: /* PAD_CFG_NF(GPP_A10, NONE, PLTRST, NF1), */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/65431855_24c45c64 PS1, Line 91: _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF), 0), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/803a1095_799082c2 PS1, Line 91: _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF), 0), please, no spaces at the start of a line
File src/mainboard/acer/swift3-SF314-52G-55WQ/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b077ecc2_eb0badb2 PS1, Line 28: uint32_t tpm_resp=0; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/633bb673_b670d728 PS1, Line 29: uint8_t tpm_b=0; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6688d08d_47a9d4ff PS1, Line 30: uint32_t count=0x2EE; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c1afbb49_ed16b00c PS1, Line 33: do that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2656dc40_e59f2990 PS1, Line 35: tpm_resp = *(uint32_t*)(0xFED40000); "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/137e948d_825a80d8 PS1, Line 36: tpm_b=tpm_resp & 0x000000FF; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/841fd9ac_4301d249 PS1, Line 38: if (tpm_b == 0xFF) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/473feefd_156a2cd7 PS1, Line 43: if ( (tpm_b & 0x80) == 0x80) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/91f18f83_14db62c3 PS1, Line 43: if ( (tpm_b & 0x80) == 0x80) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4a018dc8_a4ba6f61 PS1, Line 81: uint32_t tmp=0; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2a710daf_b9ff15fa PS1, Line 83: uint8_t tmpb2=0; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6f4b597a_eda016bd PS1, Line 84: uint16_t tmps=0; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/52da62a5_389618b4 PS1, Line 91: uint32_t tmp5=0; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d15af0e5_13e064ca PS1, Line 107: if ((uint8_t)(tmp >> 0x18) == 0xFF) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/49c691a3_c292f16d PS1, Line 107: if ((uint8_t)(tmp >> 0x18) == 0xFF) { please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5516e424_f6a2c049 PS1, Line 109: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/bd190a3a_da4d0fe4 PS1, Line 109: } please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/fa57dbb7_e597916e PS1, Line 120: tmpb = inb(0x0073); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/58fd53cc_b6deace8 PS1, Line 120: tmpb = inb(0x0073); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/da5d1ac9_95ee3dbe PS1, Line 121: outb(tmpb, 0x00ED); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cbea933e_3c2784bc PS1, Line 121: outb(tmpb, 0x00ED); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f58a9b5d_cb7f5ab0 PS1, Line 123: outb(tmpb, 0x0073); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e21085ad_db59e266 PS1, Line 123: outb(tmpb, 0x0073); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ddc5d545_76943db9 PS1, Line 124: outb(tmpb, 0x00ED); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/851806cd_8aabdf85 PS1, Line 124: outb(tmpb, 0x00ED); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/18f1f96e_4df31727 PS1, Line 127: tmpb = inb(0x0073); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/70eba54e_50d569d1 PS1, Line 127: tmpb = inb(0x0073); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/02a62e60_38d8f7c8 PS1, Line 135: outb(tmpb, 0x00ED); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4c231d38_0e951872 PS1, Line 135: outb(tmpb, 0x00ED); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/087a939a_d87bd77a PS1, Line 165: if ((uint8_t)(tmp >> 0x18) == 0xFF) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/24dedbae_3c660664 PS1, Line 165: if ((uint8_t)(tmp >> 0x18) == 0xFF) { please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d71e9ba4_3533f45c PS1, Line 167: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/71e9d0a0_36a58340 PS1, Line 167: } please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/775339c9_059b0d61 PS1, Line 173: tmp = inl(0xcf8); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/1bde3e7f_dd112748 PS1, Line 173: tmp = inl(0xcf8); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/22ff0526_b8c90b0d PS1, Line 173: tmp = inl(0xcf8); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/1a491cda_d3bc0b81 PS1, Line 175: outl(0x8000fa44, 0xcf8); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/dc6a49ae_fa36d4d2 PS1, Line 175: outl(0x8000fa44, 0xcf8); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ee8f68dd_3049ab9f PS1, Line 175: outl(0x8000fa44, 0xcf8); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/202abbc1_030f8288 PS1, Line 176: tmpb2 = inb(0xcfc); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/a584291b_4becf802 PS1, Line 176: tmpb2 = inb(0xcfc); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/922bb005_ba8e129d PS1, Line 176: tmpb2 = inb(0xcfc); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/59ea8193_7d0cbf3a PS1, Line 179: if (tmpb2 & 0x80) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/da7fb83d_fc16cdb4 PS1, Line 182: outl(0x8000fa40,0xcf8); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2ac2d2de_06bfe0fd PS1, Line 183: outw(0x1800,0xcfc); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/32e1fed5_259dc0be PS1, Line 185: outl(0x8000fa44, 0xcf8); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3da8e376_737872c9 PS1, Line 186: tmpb2 = inb(0xcfc); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ba12cd80_39228a09 PS1, Line 186: tmpb2 = inb(0xcfc); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/eda56e33_152cb1df PS1, Line 186: tmpb2 = inb(0xcfc); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/da7e64d3_65ad1d7e PS1, Line 189: outb(tmpb2,0xcfc); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7c31a078_0604ddb6 PS1, Line 189: outb(tmpb2,0xcfc); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/6b7c055b_7ac7f28c PS1, Line 189: outb(tmpb2,0xcfc); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/9cd8f55a_e4463676 PS1, Line 193: outl(0x8000fa40,0xcf8); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/5e156e5c_7785d14b PS1, Line 194: tmps = inw(0xcfc); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f8bc9d46_8f687c65 PS1, Line 194: tmps = inw(0xcfc); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c777016c_fbedf3e8 PS1, Line 194: tmps = inw(0xcfc); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/0bce7752_5efdcb13 PS1, Line 197: tmps=(tmps & 0xFFFC) + 8; spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/8016acfb_4aed205b PS1, Line 201: for (uint32_t i=0; i<0x2EE; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/49fd2a72_85cc34ff PS1, Line 201: for (uint32_t i=0; i<0x2EE; i++) spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4f667157_2b1042c6 PS1, Line 201: for (uint32_t i=0; i<0x2EE; i++) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/410c5f5e_5ab4774c PS1, Line 203: uint32_t t=inl(tmps); spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/bf85f1c2_9359f53c PS1, Line 204: if ( ((tmp5 + 0xdfb - t) & 0x00800000) == 0 ) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/b247754b_da7ade9f PS1, Line 204: if ( ((tmp5 + 0xdfb - t) & 0x00800000) == 0 ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/70db58dd_baa9a589 PS1, Line 204: if ( ((tmp5 + 0xdfb - t) & 0x00800000) == 0 ) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/16b450c1_100ef3a8 PS1, Line 212: outl(0xcf8,tmp); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/36908a08_37e38089 PS1, Line 212: outl(0xcf8,tmp); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/97b61c37_9565d2bd PS1, Line 212: outl(0xcf8,tmp); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/e9bedf17_1629e1eb PS1, Line 212: outl(0xcf8,tmp); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d63c98f0_b201ada3 PS1, Line 213: tmp5=0; spaces required around that '=' (ctx:VxV)
File src/superio/ite/it8987e/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/af9d0977_346a0c3b PS1, Line 18: if (!dev->enabled) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/88f7b97f_ef9cf0a3 PS1, Line 18: if (!dev->enabled) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/76958e14_f340e84e PS1, Line 19: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/4c5a1c05_ef14d546 PS1, Line 19: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/77da5279_dbd906dc PS1, Line 21: switch (dev->path.pnp.device) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f936c5f1_9efa2311 PS1, Line 21: switch (dev->path.pnp.device) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f054a21d_bdb621c3 PS1, Line 22: case IT8987E_KBCK: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/38766dcb_1e7f6c56 PS1, Line 22: case IT8987E_KBCK: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/8ee2424c_cc91a43e PS1, Line 23: pc_keyboard_init(NO_AUX_DEVICE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/921fded1_92c7b219 PS1, Line 23: pc_keyboard_init(NO_AUX_DEVICE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3993c3e0_f4c7dbfe PS1, Line 24: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2dc4f34e_f10aee12 PS1, Line 24: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/2ed1b4f4_02ee2e15 PS1, Line 25: default: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/bc0f6aae_96549736 PS1, Line 27: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/dcda6c13_d4ab71f1 PS1, Line 27: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/c89e4eb1_cb7acf68 PS1, Line 28: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/43e39b2a_b03e540d PS1, Line 28: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/3f20f10e_230ed66a PS1, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7be63171_360300b3 PS1, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/d161c5ae_455ccdd9 PS1, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/30fe4aac_3adc2ba9 PS1, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/bb49130d_d8ccef20 PS1, Line 65: const struct superio_ite_it8987e_config *conf; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/29c70382_ee29fd76 PS1, Line 65: const struct superio_ite_it8987e_config *conf; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/57728111_8e6ef3b0 PS1, Line 69: conf = dev->chip_info; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/ca3fbc84_746f1ec3 PS1, Line 69: conf = dev->chip_info; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7b1b5487_cfafb37c PS1, Line 70: if (!conf) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/212701d8_6251bd09 PS1, Line 70: if (!conf) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/f19420f5_3848d54d PS1, Line 70: if (!conf) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/07b11391_5f0cb9cf PS1, Line 74: printk(BIOS_INFO, "IT8987E: init ITE EC\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/7015be06_d57c5398 PS1, Line 75: ite_ec_init(0x25e, &conf->ec); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/cd138d6d_8f3b304e PS1, Line 75: ite_ec_init(0x25e, &conf->ec); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169889): https://review.coreboot.org/c/coreboot/+/72788/comment/faff9471_ec237c64 PS1, Line 75: ite_ec_init(0x25e, &conf->ec); please, no spaces at the start of a line