Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 15: gpio_table Cnvi would need below GPIO also:
/* MODEM CLKREQ */ PAD_CFG_NF(GPP_H2, NONE, DEEP, NF3),
/* Cnvi RST */ PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1),
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 330: PAD_NC(GPP_H19, NONE), BT disable needs to driven high as well
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 3: 3 1c.7