Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33379 )
Change subject: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti... File src/soc/intel/apollolake/meminit_util_apl.c:
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti... PS1, Line 98: 0);
Does coreboot (at any stage) read SPD directly, or is this only done by FSP? Is there value if core […]
I don't believe there are APL designs with actual DIMM and SPD, they should all be LPDDR.
https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c File src/soc/intel/common/smbios.c:
https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c@29 PS1, Line 29: dimm->mod_id = mod_id; : /* Translate to DDR2 module type field that SMBIOS code expects. */ : switch (mod_type) { : case SPD_DIMM_TYPE_SO_DIMM: : dimm->mod_type = SPD_SODIMM; : break; : case SPD_DIMM_TYPE_72B_SO_CDIMM: : dimm->mod_type = SPD_72B_SO_CDIMM; : break; : case SPD_DIMM_TYPE_72B_SO_RDIMM: : dimm->mod_type = SPD_72B_SO_RDIMM; : break; : case SPD_DIMM_TYPE_UDIMM: : dimm->mod_type = SPD_UDIMM; : break; : case SPD_DIMM_TYPE_RDIMM: : dimm->mod_type = SPD_RDIMM; : break; : case SPD_DIMM_TYPE_UNDEFINED: : default: : dimm->mod_type = SPD_UNDEFINED; : break; : }
SMBIOS spec doesn't, but src/arch/x86/smbios.c is expecting DDR2 values.
Yes exactly, I started on a set of changes to clean that up but it isn't going to happen until I get back in a few weeks.