Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40592 )
Change subject: drivers/intel/gma: put controller in separate header ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40592/1/src/drivers/intel/gma/i915_... File src/drivers/intel/gma/i915_gma.h:
https://review.coreboot.org/c/coreboot/+/40592/1/src/drivers/intel/gma/i915_... PS1, Line 10: {
open brace '{' following struct go on the same line
I agree
https://review.coreboot.org/c/coreboot/+/40592/1/src/drivers/intel/gma/i915_... PS1, Line 22: drivers_intel_gma_displays_ssdt_generate(const struct i915_gpu_controller_info *conf); Fiiits in 96 chars