Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37114 )
Change subject: volteer: add initial support for mainboard volteer ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37114/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/37114/3/src/mainboard/google/voltee... PS3, Line 17: select SOC_INTEL_TIGERLAKE Tigerlake support needs to be added / this is undefined without it.
https://review.coreboot.org/c/coreboot/+/37114/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/37114/3/src/mainboard/google/voltee... PS3, Line 90: LPDDR4_MC0_DISABLE Tigerlake support must be added / this is undefined without tigerlake support.