Attention is currently required from: Angel Pons, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78827?usp=email )
Change subject: sb/intel/bd82x6x/early_usb: Print error for invalid USB setting ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78827/comment/ae7e45d3_2aa43dff : PS8, Line 15: Tested: Lenovo X220 still boots.
Isn't this a laptop? This change should be a no-op for mobile PCHs.
That's correct.
File src/southbridge/intel/bd82x6x/early_usb.c:
https://review.coreboot.org/c/coreboot/+/78827/comment/3a6a0935_cc9e027a : PS8, Line 28: if (!pch_is_mobile() && portmap[i].current == 0) {
We may want to skip complaining about disabled ports. […]
Done
https://review.coreboot.org/c/coreboot/+/78827/comment/d439d065_cd8b9a04 : PS8, Line 29: Consult the OEM for correct settings
As most Sandy/Ivy Bridge ports are retrofits (people add coreboot support without OEM involvement), […]
Done