[coreboot-gerrit] Change in coreboot[master]: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI

[Nico Huber (Code Review)]

Attention is currently required from: Subrata Banik, Paul Menzel, Arthur Heymans, Werner Zeh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63982 )

Change subject: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI
......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS1:
> Hmm. […]

For APL sounds good. There wouldn't be anything to do for the new driver beside
writing the SSDT. So it's not needed for all SoCs. I guess GLK, SKL, KBL and CFL
are candidates for the same fix, but should be tested individually.

File src/soc/intel/common/block/spi/spi.c:

https://review.coreboot.org/c/coreboot/+/63982/comment/3d5d5586_e71f417f 
PS1, Line 117: spi_fill_ssdt
> In general yes. […]

The `hidden` keyword is a hack for devices that are hidden from coreboot.
So `dev->hidden` is actually reliable, it has to be. But it serves a different
purpose.