Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45032 )
Change subject: src/arch/x86: Fix register accesses for x86_64 debugging ......................................................................
Patch Set 2:
(2 comments)
To avoid future breakages, it’d be great, if you added a build configuration in a separate commit, cf. `configs/` in the repository.
https://review.coreboot.org/c/coreboot/+/45032/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45032/2//COMMIT_MSG@11 PS2, Line 11: Because those registers are rip and rflags in x86_64, compilation would Please add a blank line between paragraphs.
https://review.coreboot.org/c/coreboot/+/45032/2//COMMIT_MSG@16 PS2, Line 16: Please add the tag:
TEST=
and maybe say, what you tested.