Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine : Provide initial mainboard support ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45206/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45206/15//COMMIT_MSG@7 PS15, Line 7: herobrine : Please remove the space before the colon.
https://review.coreboot.org/c/coreboot/+/45206/15//COMMIT_MSG@8 PS15, Line 8: 1. Is this code copied? 2. What payload was used? 3. What works?
https://review.coreboot.org/c/coreboot/+/45206/15/payloads/libpayload/Kconfi... File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/15/payloads/libpayload/Kconfi... PS15, Line 262: default n Please split out the libpayload changes into a separate commit.