Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35229 )
Change subject: src/soc/inte/common/block/cse: Add hmrfpo related functions to cse lib
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35229/14/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35229/14/src/soc/intel/common/block...
PS14, Line 595: u8 group_id;
: u8 command;
: u8 reserved;
: u8 result;
can be replaced by mkhi_hdr
https://review.coreboot.org/c/coreboot/+/35229/14/src/soc/intel/common/block...
PS14, Line 601: u8 group_id;
: u8 cmd;
: u8 reserved;
: u8 result;
: u8 req_origin;
can be replaced by mkhi_hdr
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I559bc4641e12df7ed39b1c97097bf068f9a232db
Gerrit-Change-Number: 35229
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Sep 2019 09:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment