Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Sridhar Siricilla, Deepti Deshatty, Patrick Rudolph. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54733 )
Change subject: intel/common/block: Move mainboard api to tcss common block ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54733/comment/6658639f_44966e55 PS7, Line 9: As per the comments in CB:54090 mainboard api : mainboard_tcss_get_port_info() is simplified and moved : to tcss common block code.
This text should be 72 characters wide
Ack
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/54733/comment/a7319f4c_44e9252b PS5, Line 372: const struct device_path conn_path[] = { : {.type = DEVICE_PATH_GENERIC, .generic.id = port, .generic.subid = 0}, : }; : const struct device *conn = find_dev_nested_path(mux->link_list, conn_path, : ARRAY_SIZE(conn_path));
You can get rid of the two above sections and just add the PMC device into this list here: […]
Done
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/54733/comment/2b245821_7e87913c PS7, Line 346: static struct tcss_port_map port_map[MAX_TYPE_C_PORTS];
nit: place static variables first in the declaration order
Ack