Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42833 )
Change subject: soc/amd/picasso/soc_util: add function to detect defeatured SKU ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 212: bool soc_is_defeatured_sku(void)
less PCIe lanes, no second XHCI controller, less USB3 ports, no 4th display port, only 2C/4T and may […]
Maybe soc_has_reduced_io or soc_is_reduced_io_sku
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 214: SILICON_RV2
it would be equivalent, but i'm not sure if i should use the functions here that are mostly there fo […]
I prefer improved readability whenever possible. I don't know about the CPUID issues.