Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37863 )
Change subject: mb/intel/tglrvp: Enable MIPI Camera
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/...
PS7, Line 4: 2019
2020
Ack
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/...
PS7, Line 68: c
nit: capital "C" to be consistent with other comments
Ack
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/...
PS7, Line 29:
Why is there a blank line here? If there's a reason for separating lines 30 and 31 from other camer […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4189e96f68f0e64e0860405e00eeab84564b86be
Gerrit-Change-Number: 37863
Gerrit-PatchSet: 9
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Jan 2020 07:55:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment