Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38862 )
Change subject: superio/nuvoton/npcd378: Switch to superio/common
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38862/2/src/superio/nuvoton/npcd378...
File src/superio/nuvoton/npcd378/superio.c:
https://review.coreboot.org/c/coreboot/+/38862/2/src/superio/nuvoton/npcd378...
PS2, Line 423: "L%02X0"
npcd378_acpi_name hard-codes the virtual ldn number to 0, while superio_common_ldn_acpi_name uses th […]
The virtual LDN is always zero on NPCD. Using superio_common_ldn_acpi_name as it's less code.
Tested on HP z220, no issue could be found.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41616d9bf320fd2b4d8495892b8190cd2a2d057f
Gerrit-Change-Number: 38862
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Mar 2020 10:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment
