Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39106 )
Change subject: mb/51nb/x210: add libgfxinit support
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39106/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39106/9//COMMIT_MSG@12
PS9, Line 12: internal
eDP
Done
https://review.coreboot.org/c/coreboot/+/39106/9/src/mainboard/51nb/x210/gma...
File src/mainboard/51nb/x210/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/39106/9/src/mainboard/51nb/x210/gma...
PS9, Line 26: Internal
This should now be eDP
Done
https://review.coreboot.org/c/coreboot/+/39106/9/src/mainboard/51nb/x210/gma...
PS9, Line 27: others
Please capitalize "Others"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b79b236a458ebd243c992d6e615e41930eeb50
Gerrit-Change-Number: 39106
Gerrit-PatchSet: 10
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matthew Garrett
mjg59@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Mar 2020 21:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment