[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure THC

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41571 )

Change subject: soc/intel/tigerlake: Configure THC
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41571/3/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/41571/3/src/soc/intel/tigerlake/fsp... 
PS3, Line 223: 	else
             : 		params->ThcPort1Assignment = dev->enabled;
shouldn't this be:
`else if (dev->enabled)
         params->ThcPort1Assignment = 2`;

And the 2 should probably be a macro for ThcAssignmentThc1 (according to the UPD).