Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31943 )
Change subject: vboot: deprecate physical dev switch ......................................................................
Patch Set 3:
(3 comments)
I don't know the details, I thought virtual dev switch depended on chrome-ec.
Thanks for pointing out that GPIO code.
Virtual dev switch depends on being able to enter recovery mode. The process for entering recovery mode depends on the particular device -- for most, a keyboard combination is used (Esc+Refresh+Power) which indeed depends on Chrome EC. For others, a physical recovery mode button is used, which does not require Chrome EC.
So in short: no, it doesn't and never did depend on the EC (virtual *recovery* switch does, but that's something else). It does depend on the TPM, but all Chromebooks (even the ones that still used physical dev switches) have one, so I hope (although we're not gonna dig out the 7 year old hardware to test it) that the virtual switch would just work on a Lumpy after this patch.
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/lumpy/chromeos... File src/mainboard/samsung/lumpy/chromeos.c:
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/lumpy/chromeos... PS3, Line 61: 3 Uhh... fix GPIO_COUNT and remove the gap please. Otherwise there'll be uninitialized garbage in the table (or possibly zeroes, not quite sure, but neither of that is good).
In fact, it would be nice to update this to use the newer, more compact (and more fool-proof) lb_add_gpios() notation, if you want to go that extra mile.
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/lumpy/chromeos... PS3, Line 119: static const struct cros_gpio cros_gpios[] = { Do we wanna get rid of the CROS_GPIO_DEV_AL/AH macros as well while we're at it? And maybe remove or at least rename the CROS_GPIO_DEV enum value.
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/stumpy/chromeo... File src/mainboard/samsung/stumpy/chromeos.c:
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/stumpy/chromeo... PS3, Line 58: gpios->gpios[3].port = 100; Same here.