Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33641 )
Change subject: Kconfig: Display a warning if the board is updated incorrectly
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33641/1/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/33641/1/src/Kconfig@1075
PS1, Line 1075: string "Mainboard dir - Do not change manually"
do we need a text description for this? If you remove it, the variable should be invisible
If it doesn't have a prompt, it will get updated automatically to the default value, and the whole process won't work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33641
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a1ccb62c7678f264015c87b9004be6a106f804a
Gerrit-Change-Number: 33641
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Tue, 30 Jul 2019 22:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment